Skip to content

Commit 7685297

Browse files
lpincaBethGriggs
authored andcommitted
test: add ALPNProtocols option to clientOptions
Without this, the session is destroyed with the following error ``` Error [ERR_HTTP2_ERROR]: Protocol error at Http2Session.onSessionInternalError (internal/http2/core.js:756:26) Emitted 'error' event on ClientHttp2Session instance at: at emitClose (internal/http2/core.js:1010:10) at internal/http2/core.js:1048:7 at finish (internal/streams/writable.js:731:5) at processTicksAndRejections (internal/process/task_queues.js:80:21) { code: 'ERR_HTTP2_ERROR', errno: -505 } ``` The test then calls `session.close()` which tries to write to a destroyed socket. As a result, an unhandled `ECONNRESET` error is emitted in the v12 release line. PR-URL: #35482 Refs: #34859 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]>
1 parent 85dc84d commit 7685297

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

test/parallel/test-http2-connect.js

+1
Original file line numberDiff line numberDiff line change
@@ -95,6 +95,7 @@ const { connect: tlsConnect } = require('tls');
9595
};
9696

9797
const clientOptions = {
98+
ALPNProtocols: ['h2'],
9899
port,
99100
rejectUnauthorized: false
100101
};

0 commit comments

Comments
 (0)