Skip to content

Commit 7816e04

Browse files
atlowChemiRafaelGSS
authored andcommitted
test: stabilize the inspector-open-dispose test
Ref: https://ci.nodejs.org/job/node-test-commit-osx-arm/nodes\=osx11/12543/console, nodejs/reliability#631 PR-URL: #49000 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
1 parent e70e974 commit 7816e04

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

test/parallel/test-inspector-open-dispose.mjs test/sequential/test-inspector-open-dispose.mjs

+4-4
Original file line numberDiff line numberDiff line change
@@ -15,16 +15,16 @@ if (process.env.BE_CHILD) {
1515

1616
child.once('message', common.mustCall((msg) => {
1717
assert.strictEqual(msg.cmd, 'started');
18+
assert.strictEqual(msg.url, undefined);
1819

19-
child.send({ cmd: 'open', args: [] });
20+
child.send({ cmd: 'open' });
2021
child.once('message', common.mustCall(wasOpenedHandler));
2122
}));
2223

2324
function wasOpenedHandler(msg) {
2425
assert.strictEqual(msg.cmd, 'url');
25-
const port = url.parse(msg.url).port;
26+
const { port } = url.parse(msg.url);
2627
ping(port, common.mustSucceed(() => {
27-
// Inspector is already open, and won't be reopened, so args don't matter.
2828
child.send({ cmd: 'dispose' });
2929
child.once('message', common.mustCall(wasDisposedWhenOpenHandler));
3030
firstPort = port;
@@ -35,7 +35,7 @@ if (process.env.BE_CHILD) {
3535
assert.strictEqual(msg.cmd, 'url');
3636
assert.strictEqual(msg.url, undefined);
3737
ping(firstPort, (err) => {
38-
assert(err);
38+
assert(err, 'expected ping to inspector port to fail');
3939
child.send({ cmd: 'dispose' });
4040
child.once('message', common.mustCall(wasReDisposedHandler));
4141
});

0 commit comments

Comments
 (0)