Skip to content

Commit 7852117

Browse files
bnoordhuisMyles Borins
authored and
Myles Borins
committed
src: fix readability/inheritance cpplint warnings
PR-URL: #7462 Reviewed-By: Trevor Norris <[email protected]>
1 parent c90ae7f commit 7852117

5 files changed

+9
-9
lines changed

src/async-wrap.cc

+5-5
Original file line numberDiff line numberDiff line change
@@ -39,11 +39,11 @@ class RetainedAsyncInfo: public RetainedObjectInfo {
3939
public:
4040
explicit RetainedAsyncInfo(uint16_t class_id, AsyncWrap* wrap);
4141

42-
virtual void Dispose() override;
43-
virtual bool IsEquivalent(RetainedObjectInfo* other) override;
44-
virtual intptr_t GetHash() override;
45-
virtual const char* GetLabel() override;
46-
virtual intptr_t GetSizeInBytes() override;
42+
void Dispose() override;
43+
bool IsEquivalent(RetainedObjectInfo* other) override;
44+
intptr_t GetHash() override;
45+
const char* GetLabel() override;
46+
intptr_t GetSizeInBytes() override;
4747

4848
private:
4949
const char* label_;

src/cares_wrap.cc

+1-1
Original file line numberDiff line numberDiff line change
@@ -256,7 +256,7 @@ class QueryWrap : public AsyncWrap {
256256
req_wrap_obj->Set(env->domain_string(), env->domain_array()->Get(0));
257257
}
258258

259-
virtual ~QueryWrap() override {
259+
~QueryWrap() override {
260260
CHECK_EQ(false, persistent().IsEmpty());
261261
persistent().Reset();
262262
}

src/fs_event_wrap.cc

+1-1
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ class FSEventWrap: public HandleWrap {
3434

3535
private:
3636
FSEventWrap(Environment* env, Local<Object> object);
37-
virtual ~FSEventWrap() override;
37+
~FSEventWrap() override;
3838

3939
static void OnEvent(uv_fs_event_t* handle, const char* filename, int events,
4040
int status);

src/handle_wrap.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ class HandleWrap : public AsyncWrap {
4848
uv_handle_t* handle,
4949
AsyncWrap::ProviderType provider,
5050
AsyncWrap* parent = nullptr);
51-
virtual ~HandleWrap() override;
51+
~HandleWrap() override;
5252

5353
private:
5454
friend class Environment;

src/node_stat_watcher.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ namespace node {
1111

1212
class StatWatcher : public AsyncWrap {
1313
public:
14-
virtual ~StatWatcher() override;
14+
~StatWatcher() override;
1515

1616
static void Initialize(Environment* env, v8::Local<v8::Object> target);
1717

0 commit comments

Comments
 (0)