Skip to content

Commit 78592a3

Browse files
danbevMylesBorins
authored andcommitted
test: make CreateParams stack-allocated
PR-URL: #17366 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
1 parent ca81d4b commit 78592a3

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

test/cctest/node_test_fixture.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,6 @@ class NodeTestFixture : public ::testing::Test {
6161
node::MultiIsolatePlatform* Platform() const { return platform_; }
6262

6363
protected:
64-
v8::Isolate::CreateParams params_;
6564
v8::Isolate* isolate_;
6665

6766
~NodeTestFixture() {
@@ -73,6 +72,7 @@ class NodeTestFixture : public ::testing::Test {
7372
platform_ = new node::NodePlatform(8, nullptr);
7473
v8::V8::InitializePlatform(platform_);
7574
v8::V8::Initialize();
75+
v8::Isolate::CreateParams params_;
7676
params_.array_buffer_allocator = allocator_.get();
7777
isolate_ = v8::Isolate::New(params_);
7878
}

0 commit comments

Comments
 (0)