Skip to content

Commit 79bd39c

Browse files
targosMyles Borins
authored and
Myles Borins
committed
build: add v8 requirement to test-v8* in Makefile
The test targets expect that V8 is built in deps/v8/out Ref: #7477 PR-URL: #7482 Reviewed-By: Myles Borins <[email protected]> Reviewed-By: James M Snell <[email protected]>
1 parent b956635 commit 79bd39c

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

Makefile

+3-3
Original file line numberDiff line numberDiff line change
@@ -227,22 +227,22 @@ test-timers:
227227
test-timers-clean:
228228
$(MAKE) --directory=tools clean
229229

230-
test-v8:
230+
test-v8: v8
231231
# note: performs full test unless QUICKCHECK is specified
232232
deps/v8/tools/run-tests.py --arch=$(V8_ARCH) \
233233
--mode=$(BUILDTYPE_LOWER) $(V8_TEST_NO_I18N) $(QUICKCHECK_ARG) \
234234
--no-presubmit \
235235
--shell-dir=$(PWD)/deps/v8/out/$(V8_ARCH).$(BUILDTYPE_LOWER) \
236236
$(TAP_V8)
237237

238-
test-v8-intl:
238+
test-v8-intl: v8
239239
# note: performs full test unless QUICKCHECK is specified
240240
deps/v8/tools/run-tests.py --arch=$(V8_ARCH) \
241241
--mode=$(BUILDTYPE_LOWER) --no-presubmit $(QUICKCHECK_ARG) \
242242
--shell-dir=deps/v8/out/$(V8_ARCH).$(BUILDTYPE_LOWER) intl \
243243
$(TAP_V8_INTL)
244244

245-
test-v8-benchmarks:
245+
test-v8-benchmarks: v8
246246
deps/v8/tools/run-tests.py --arch=$(V8_ARCH) --mode=$(BUILDTYPE_LOWER) \
247247
--download-data $(QUICKCHECK_ARG) --no-presubmit \
248248
--shell-dir=deps/v8/out/$(V8_ARCH).$(BUILDTYPE_LOWER) benchmarks \

0 commit comments

Comments
 (0)