File tree 1 file changed +6
-1
lines changed
1 file changed +6
-1
lines changed Original file line number Diff line number Diff line change @@ -229,7 +229,7 @@ to be cherry-picked in the Node.js repository and V8-CI must test the change.
229
229
* Run the Node.js [ V8 CI] [ ] in addition to the [ Node.js CI] [ ] .
230
230
The CI uses the ` test-v8 ` target in the ` Makefile ` , which uses
231
231
` tools/make-v8.sh ` to reconstruct a git tree in the ` deps/v8 ` directory to
232
- run V8 tests.
232
+ run V8 tests< sup >2</ sup > .
233
233
234
234
The [ ` git-node ` ] [ ] tool can be used to simplify this task. Run
235
235
` git node v8 backport <sha> ` to cherry-pick a commit.
@@ -414,6 +414,11 @@ This would require some tooling to:
414
414
<sup >1</sup >Node.js 0.12 and older are intentionally omitted from this document
415
415
as their support has ended.
416
416
417
+ <sup >2</sup >The V8 tests still require Python 2. To run these tests locally,
418
+ you can run ` PYTHON2 ./configure.py ` before running ` make test-v8 ` , in the root
419
+ of this repository. On macOS, this also requires a full Xcode install,
420
+ not just the "command line tools" for Xcode.
421
+
417
422
[ ChromiumReleaseCalendar ] : https://www.chromium.org/developers/calendar
418
423
[ Node.js CI ] : https://ci.nodejs.org/job/node-test-pull-request/
419
424
[ Node.js `canary` branch ] : https://github.com/nodejs/node-v8/tree/canary
You can’t perform that action at this time.
0 commit comments