Skip to content

Commit 7a5ff3f

Browse files
DeeDeeGtargos
authored andcommitted
doc: note the system requirements for V8 tests
The `test-v8` Makefile target still requires Python 2, and it requires a full Xcode install on macOS. Refs: #36691 PR-URL: #38319 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
1 parent 3509b0a commit 7a5ff3f

File tree

1 file changed

+6
-1
lines changed

1 file changed

+6
-1
lines changed

doc/guides/maintaining-V8.md

+6-1
Original file line numberDiff line numberDiff line change
@@ -229,7 +229,7 @@ to be cherry-picked in the Node.js repository and V8-CI must test the change.
229229
* Run the Node.js [V8 CI][] in addition to the [Node.js CI][].
230230
The CI uses the `test-v8` target in the `Makefile`, which uses
231231
`tools/make-v8.sh` to reconstruct a git tree in the `deps/v8` directory to
232-
run V8 tests.
232+
run V8 tests<sup>2</sup>.
233233

234234
The [`git-node`][] tool can be used to simplify this task. Run
235235
`git node v8 backport <sha>` to cherry-pick a commit.
@@ -414,6 +414,11 @@ This would require some tooling to:
414414
<sup>1</sup>Node.js 0.12 and older are intentionally omitted from this document
415415
as their support has ended.
416416

417+
<sup>2</sup>The V8 tests still require Python 2. To run these tests locally,
418+
you can run `PYTHON2 ./configure.py` before running `make test-v8`, in the root
419+
of this repository. On macOS, this also requires a full Xcode install,
420+
not just the "command line tools" for Xcode.
421+
417422
[ChromiumReleaseCalendar]: https://www.chromium.org/developers/calendar
418423
[Node.js CI]: https://ci.nodejs.org/job/node-test-pull-request/
419424
[Node.js `canary` branch]: https://github.com/nodejs/node-v8/tree/canary

0 commit comments

Comments
 (0)