Skip to content

Commit 7b0d867

Browse files
committed
build: fix test failures not failing Travis builds
The exit code of the make command used to execute tests was being lost after being piped through to grep. PR-URL: #27176 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Minwoo Jung <[email protected]>
1 parent 25df3c1 commit 7b0d867

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

.travis.yml

+1
Original file line numberDiff line numberDiff line change
@@ -65,4 +65,5 @@ jobs:
6565
- make -j2 > /dev/null
6666
- make -j1 build-addons build-js-native-api-tests build-node-api-tests > /dev/null
6767
script:
68+
- set -o pipefail
6869
- JOBS=2 FLAKY_TESTS=dontcare make -s -j1 V= test-ci | grep -F -e "---" -e "..." -v

0 commit comments

Comments
 (0)