Skip to content

Commit 7b4a72d

Browse files
committed
errors: add space between error name and code
`Error[CODE]` becomes `Error [CODE]` PR-URL: #12099 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Evan Lucas <[email protected]>
1 parent 9b05393 commit 7b4a72d

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

lib/internal/errors.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ function makeNodeError(Base) {
2626
}
2727

2828
get name() {
29-
return `${super.name}[${this[kCode]}]`;
29+
return `${super.name} [${this[kCode]}]`;
3030
}
3131

3232
get code() {

test/parallel/test-internal-errors.js

+5-5
Original file line numberDiff line numberDiff line change
@@ -15,27 +15,27 @@ const err4 = new errors.Error('TEST_ERROR_2', 'abc', 'xyz');
1515
const err5 = new errors.Error('TEST_ERROR_1');
1616

1717
assert(err1 instanceof Error);
18-
assert.strictEqual(err1.name, 'Error[TEST_ERROR_1]');
18+
assert.strictEqual(err1.name, 'Error [TEST_ERROR_1]');
1919
assert.strictEqual(err1.message, 'Error for testing purposes: test');
2020
assert.strictEqual(err1.code, 'TEST_ERROR_1');
2121

2222
assert(err2 instanceof TypeError);
23-
assert.strictEqual(err2.name, 'TypeError[TEST_ERROR_1]');
23+
assert.strictEqual(err2.name, 'TypeError [TEST_ERROR_1]');
2424
assert.strictEqual(err2.message, 'Error for testing purposes: test');
2525
assert.strictEqual(err2.code, 'TEST_ERROR_1');
2626

2727
assert(err3 instanceof RangeError);
28-
assert.strictEqual(err3.name, 'RangeError[TEST_ERROR_1]');
28+
assert.strictEqual(err3.name, 'RangeError [TEST_ERROR_1]');
2929
assert.strictEqual(err3.message, 'Error for testing purposes: test');
3030
assert.strictEqual(err3.code, 'TEST_ERROR_1');
3131

3232
assert(err4 instanceof Error);
33-
assert.strictEqual(err4.name, 'Error[TEST_ERROR_2]');
33+
assert.strictEqual(err4.name, 'Error [TEST_ERROR_2]');
3434
assert.strictEqual(err4.message, 'abc xyz');
3535
assert.strictEqual(err4.code, 'TEST_ERROR_2');
3636

3737
assert(err5 instanceof Error);
38-
assert.strictEqual(err5.name, 'Error[TEST_ERROR_1]');
38+
assert.strictEqual(err5.name, 'Error [TEST_ERROR_1]');
3939
assert.strictEqual(err5.message, 'Error for testing purposes: %s');
4040
assert.strictEqual(err5.code, 'TEST_ERROR_1');
4141

0 commit comments

Comments
 (0)