Skip to content

Commit 7b801b5

Browse files
cjihrigMylesBorins
authored andcommitted
test: don't skip when common.mustCall() is pending
The test parallel/test-dgram-multicast-set-interface.js was calling common.skip() on hosts that do not support IPv6. However, by this point, there were several outstanding common.mustCall() invocations. The process.exit() in common.skip() triggered those common.mustCall()s as errors. Fixes: #15419 PR-URL: #15421 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Brian White <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]>
1 parent 8f2e52a commit 7b801b5

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

test/parallel/test-dgram-multicast-set-interface.js

+4-3
Original file line numberDiff line numberDiff line change
@@ -72,10 +72,11 @@ const dgram = require('dgram');
7272
}));
7373
}
7474

75-
if (!common.hasIPv6) {
76-
common.skip('Skipping udp6 tests, no IPv6 support.');
75+
// If IPv6 is not supported, skip the rest of the test. However, don't call
76+
// common.skip(), which calls process.exit() while there is outstanding
77+
// common.mustCall() activity.
78+
if (!common.hasIPv6)
7779
return;
78-
}
7980

8081
{
8182
const socket = dgram.createSocket('udp6');

0 commit comments

Comments
 (0)