Skip to content

Commit 7be1a1c

Browse files
jasonginjasnell
authored andcommitted
test: fix build warning in addons-napi/test_object
PR-URL: #13412 Reviewed-By: Anna Henningsen <[email protected]>
1 parent fb73070 commit 7be1a1c

File tree

1 file changed

+6
-3
lines changed

1 file changed

+6
-3
lines changed

test/addons-napi/test_object/test_object.c

+6-3
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,8 @@
33
#include <string.h>
44
#include <stdlib.h>
55

6+
static int test_value = 3;
7+
68
napi_value Get(napi_env env, napi_callback_info info) {
79
size_t argc = 2;
810
napi_value args[2];
@@ -145,7 +147,7 @@ napi_value Wrap(napi_env env, napi_callback_info info) {
145147
NAPI_CALL(env, napi_get_cb_info(env, info, &argc, &arg, NULL, NULL));
146148

147149
int32_t* data = malloc(sizeof(int32_t));
148-
*data = 3;
150+
*data = test_value;
149151
NAPI_CALL(env, napi_wrap(env, arg, data, NULL, NULL, NULL));
150152
return NULL;
151153
}
@@ -155,11 +157,12 @@ napi_value Unwrap(napi_env env, napi_callback_info info) {
155157
napi_value arg;
156158
NAPI_CALL(env, napi_get_cb_info(env, info, &argc, &arg, NULL, NULL));
157159

158-
int32_t* data;
160+
void* data;
159161
NAPI_CALL(env, napi_unwrap(env, arg, &data));
160162

163+
bool is_expected = (data != NULL && *(int*)data == 3);
161164
napi_value result;
162-
NAPI_CALL(env, napi_get_boolean(env, data != NULL && *data == 3, &result));
165+
NAPI_CALL(env, napi_get_boolean(env, is_expected, &result));
163166
return result;
164167
}
165168

0 commit comments

Comments
 (0)