Skip to content

Commit 7d0ffee

Browse files
bnoordhuisBridgeAR
authored andcommitted
build: unbreak --with-intl=system-icu build
Include directories are configured by the tools/icu/icu-*.gyp files. The v8.gyp file doesn't need to add them and in fact the way it did that breaks when building against an external copy of ICU. Fixes: #28052 PR-URL: #28118 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Refael Ackermann (רפאל פלחי) <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: James M Snell <[email protected]>
1 parent 0931f7e commit 7d0ffee

File tree

1 file changed

+0
-7
lines changed

1 file changed

+0
-7
lines changed

tools/v8_gypfiles/v8.gyp

-7
Original file line numberDiff line numberDiff line change
@@ -393,13 +393,6 @@
393393
'<(icu_gyp_path):icui18n',
394394
'<(icu_gyp_path):icuuc',
395395
],
396-
'direct_dependent_settings': {
397-
'include_dirs': [
398-
'<(icu_path)/source/common',
399-
'<(icu_path)/source/i18n',
400-
'<(icu_path)/source/tools/toolutil',
401-
],
402-
},
403396
}],
404397
],
405398
}, # v8_maybe_icu

0 commit comments

Comments
 (0)