Skip to content

Commit 7dbb0d0

Browse files
RReverserMyles Borins
authored and
Myles Borins
committed
buffer: fix dataview-set benchmark
Improves numbers up to 4x by avoiding repetitive dynamic method lookup. PR-URL: #6922 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Trevor Norris <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Brian White <[email protected]>
1 parent 20d3378 commit 7dbb0d0

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

benchmark/buffers/dataview-set.js

+5-3
Original file line numberDiff line numberDiff line change
@@ -40,18 +40,20 @@ function main(conf) {
4040
}
4141

4242
function benchInt(dv, fn, len, le) {
43-
var m = mod[fn];
43+
const m = mod[fn];
44+
const method = dv[fn];
4445
bench.start();
4546
for (var i = 0; i < len; i++) {
46-
dv[fn](0, i % m, le);
47+
method.call(dv, 0, i % m, le);
4748
}
4849
bench.end(len / 1e6);
4950
}
5051

5152
function benchFloat(dv, fn, len, le) {
53+
const method = dv[fn];
5254
bench.start();
5355
for (var i = 0; i < len; i++) {
54-
dv[fn](0, i * 0.1, le);
56+
method.call(dv, 0, i * 0.1, le);
5557
}
5658
bench.end(len / 1e6);
5759
}

0 commit comments

Comments
 (0)