Skip to content

Commit 7f3aec7

Browse files
Trotttargos
authored andcommitted
test: use reserved .invalid TLD for invalid address in test
RFC 2606 reserves ithe .invalid top-level-domain for use in "domain names that are sure to be invalid and which it is obvious at a glance are invalid." Replace `dne.example.com` which actually isn't guaranteed to not exist. (example.com is for examples, but at least one address does in fact exist in that TLD.) PR-URL: #30545 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
1 parent 36b6b05 commit 7f3aec7

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

test/internet/test-dgram-send-cb-quelches-error.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ function callbackOnly(err) {
2424
assert.ok(err);
2525
socket.removeListener('error', onEvent);
2626
socket.on('error', mustCall(onError));
27-
socket.send(buffer, 0, buffer.length, 100, 'dne.example.com');
27+
socket.send(buffer, 0, buffer.length, 100, 'dne.invalid');
2828
}
2929

3030
function onEvent(err) {

0 commit comments

Comments
 (0)