Skip to content

Commit 7f85288

Browse files
ScottyVGtargos
authored andcommitted
test: remove string literal from strictEqual()
Remove 3rd argument from assert.deepStrictEqual() in test/parallel/test-stream2-writable.js to allow for debugging to work properly. PR-URL: #22512 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: George Adams <[email protected]>
1 parent a740145 commit 7f85288

File tree

1 file changed

+14
-8
lines changed

1 file changed

+14
-8
lines changed

test/parallel/test-stream2-writable.js

+14-8
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,8 @@ for (let i = 0; i < chunks.length; i++) {
5555
});
5656

5757
tw.on('finish', common.mustCall(function() {
58-
assert.deepStrictEqual(tw.buffer, chunks, 'got chunks in the right order');
58+
// got chunks in the right order
59+
assert.deepStrictEqual(tw.buffer, chunks);
5960
}));
6061

6162
chunks.forEach(function(chunk) {
@@ -72,7 +73,8 @@ for (let i = 0; i < chunks.length; i++) {
7273
});
7374

7475
tw.on('finish', common.mustCall(function() {
75-
assert.deepStrictEqual(tw.buffer, chunks, 'got chunks in the right order');
76+
// got chunks in the right order
77+
assert.deepStrictEqual(tw.buffer, chunks);
7678
}));
7779

7880
let i = 0;
@@ -94,7 +96,8 @@ for (let i = 0; i < chunks.length; i++) {
9496
let drains = 0;
9597

9698
tw.on('finish', common.mustCall(function() {
97-
assert.deepStrictEqual(tw.buffer, chunks, 'got chunks in the right order');
99+
// got chunks in the right order
100+
assert.deepStrictEqual(tw.buffer, chunks);
98101
assert.strictEqual(drains, 17);
99102
}));
100103

@@ -139,7 +142,8 @@ for (let i = 0; i < chunks.length; i++) {
139142
undefined ];
140143

141144
tw.on('finish', function() {
142-
assert.deepStrictEqual(tw.buffer, chunks, 'got the expected chunks');
145+
// got the expected chunks
146+
assert.deepStrictEqual(tw.buffer, chunks);
143147
});
144148

145149
chunks.forEach(function(chunk, i) {
@@ -177,7 +181,8 @@ for (let i = 0; i < chunks.length; i++) {
177181
undefined ];
178182

179183
tw.on('finish', function() {
180-
assert.deepStrictEqual(tw.buffer, chunks, 'got the expected chunks');
184+
// got the expected chunks
185+
assert.deepStrictEqual(tw.buffer, chunks);
181186
});
182187

183188
chunks.forEach(function(chunk, i) {
@@ -205,9 +210,10 @@ for (let i = 0; i < chunks.length; i++) {
205210

206211
tw.on('finish', common.mustCall(function() {
207212
process.nextTick(common.mustCall(function() {
208-
assert.deepStrictEqual(tw.buffer, chunks,
209-
'got chunks in the right order');
210-
assert.deepStrictEqual(callbacks._called, chunks, 'called all callbacks');
213+
// got chunks in the right order
214+
assert.deepStrictEqual(tw.buffer, chunks);
215+
// called all callbacks
216+
assert.deepStrictEqual(callbacks._called, chunks);
211217
}));
212218
}));
213219

0 commit comments

Comments
 (0)