Skip to content

Commit 7fed989

Browse files
danbevMylesBorins
authored andcommitted
deps: cherry-pick f5fad6d from upstream v8
Original commit message: This commit adds a getter for the private is_verbose_ member. The use case for this comes from Node.js where the ability to avoid calling FatalException if the TryCatch is verbose would be nice to have. BUG= Review-Url: https://codereview.chromium.org/2840803002 Cr-Commit-Position: refs/heads/master@{#45018} PR-URL: #12826 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
1 parent e8438c1 commit 7fed989

File tree

3 files changed

+10
-1
lines changed

3 files changed

+10
-1
lines changed

deps/v8/include/v8-version.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
#define V8_MAJOR_VERSION 5
1212
#define V8_MINOR_VERSION 1
1313
#define V8_BUILD_NUMBER 281
14-
#define V8_PATCH_LEVEL 104
14+
#define V8_PATCH_LEVEL 105
1515

1616
// Use 1 for candidates and 0 otherwise.
1717
// (Boolean macro values are not supported by all preprocessors.)

deps/v8/include/v8.h

+5
Original file line numberDiff line numberDiff line change
@@ -6869,6 +6869,11 @@ class V8_EXPORT TryCatch {
68696869
*/
68706870
void SetVerbose(bool value);
68716871

6872+
/**
6873+
* Returns true if verbosity is enabled.
6874+
*/
6875+
bool IsVerbose() const;
6876+
68726877
/**
68736878
* Set whether or not this TryCatch should capture a Message object
68746879
* which holds source information about where the exception

deps/v8/src/api.cc

+4
Original file line numberDiff line numberDiff line change
@@ -2395,6 +2395,10 @@ void v8::TryCatch::SetVerbose(bool value) {
23952395
is_verbose_ = value;
23962396
}
23972397

2398+
bool v8::TryCatch::IsVerbose() const {
2399+
return is_verbose_;
2400+
}
2401+
23982402

23992403
void v8::TryCatch::SetCaptureMessage(bool value) {
24002404
capture_message_ = value;

0 commit comments

Comments
 (0)