Skip to content

Commit 804b398

Browse files
author
Myles Borins
committed
deps: revert botched V8 backport
Original Commit Message: "build: cherry pick V8 change for windows DLL support" This reverts commit 92ecbc4. The original commit did not include the entire changeset PR-URL: #9610 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Ali Ijaz Sheikh <[email protected]>
1 parent a8840bb commit 804b398

File tree

1 file changed

+3
-4
lines changed

1 file changed

+3
-4
lines changed

deps/v8/build/toolchain.gypi

+3-4
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,6 @@
3939
'ubsan_vptr%': 0,
4040
'v8_target_arch%': '<(target_arch)',
4141
'v8_host_byteorder%': '<!(python -c "import sys; print sys.byteorder")',
42-
'force_dynamic_crt%': 0,
4342
# Native Client builds currently use the V8 ARM JIT and
4443
# arm/simulator-arm.cc to defer the significant effort required
4544
# for NaCl JIT support. The nacl_target_arch variable provides
@@ -1105,7 +1104,7 @@
11051104
'VCCLCompilerTool': {
11061105
'Optimization': '0',
11071106
'conditions': [
1108-
['component=="shared_library" or force_dynamic_crt==1', {
1107+
['component=="shared_library"', {
11091108
'RuntimeLibrary': '3', # /MDd
11101109
}, {
11111110
'RuntimeLibrary': '1', # /MTd
@@ -1157,7 +1156,7 @@
11571156
'StringPooling': 'true',
11581157
'BasicRuntimeChecks': '0',
11591158
'conditions': [
1160-
['component=="shared_library" or force_dynamic_crt==1', {
1159+
['component=="shared_library"', {
11611160
'RuntimeLibrary': '3', #/MDd
11621161
}, {
11631162
'RuntimeLibrary': '1', #/MTd
@@ -1348,7 +1347,7 @@
13481347
'FavorSizeOrSpeed': '0',
13491348
'StringPooling': 'true',
13501349
'conditions': [
1351-
['component=="shared_library" or force_dynamic_crt==1', {
1350+
['component=="shared_library"', {
13521351
'RuntimeLibrary': '2', #/MD
13531352
}, {
13541353
'RuntimeLibrary': '0', #/MT

0 commit comments

Comments
 (0)