http: clean up dead code and unused properties

Author: mscdex

lib/_http_common.js

@@ -126,12 +126,6 @@ function parserOnMessageComplete() {
       parser._url = '';
     }
 
-    if (!stream.upgrade)
-      // For upgraded connections, also emit this after parser.execute
-      stream.push(null);
-  }
-
-  if (stream && !parser.incoming._pendings.length) {
     // For emit end event
     stream.push(null);
   }

lib/_http_incoming.js

@@ -38,8 +38,6 @@ function IncomingMessage(socket) {
 
   this.readable = true;
 
-  this._pendings = [];
-  this._pendingIndex = 0;
   this.upgrade = null;
 
   // request (server) only
@@ -49,7 +47,6 @@ function IncomingMessage(socket) {
   // response (client) only
   this.statusCode = null;
   this.statusMessage = null;
-  this.client = this.socket;
 
   // flag for backwards compatibility grossness.
   this._consuming = false;
@@ -63,6 +60,13 @@ util.inherits(IncomingMessage, Stream.Readable);
 
 exports.IncomingMessage = IncomingMessage;
 
+Object.defineProperty(IncomingMessage.prototype, 'client', {
+  configurable: true,
+  enumerable: true,
+  get: util.deprecate(function() {
+    return this.socket;
+  }, 'client is deprecated, use socket or connection instead')
+});
 
 IncomingMessage.prototype.setTimeout = function(msecs, callback) {
   if (callback)

lib/_http_outgoing.js

@@ -62,7 +62,6 @@ function OutgoingMessage() {
   this._trailer = '';
 
   this.finished = false;
-  this._hangupClose = false;
   this._headerSent = false;
 
   this.socket = null;
@@ -148,8 +147,7 @@ OutgoingMessage.prototype._writeRaw = function(data, encoding, callback) {
       var outputEncodings = this.outputEncodings;
       var outputCallbacks = this.outputCallbacks;
       for (var i = 0; i < outputLength; i++) {
-        connection.write(output[i], outputEncodings[i],
-                         outputCallbacks[i]);
+        connection.write(output[i], outputEncodings[i], outputCallbacks[i]);
       }
 
       this.output = [];
@@ -613,8 +611,7 @@ OutgoingMessage.prototype._flush = function() {
       var outputEncodings = this.outputEncodings;
       var outputCallbacks = this.outputCallbacks;
       for (var i = 0; i < outputLength; i++) {
-        ret = socket.write(output[i], outputEncodings[i],
-                           outputCallbacks[i]);
+        ret = socket.write(output[i], outputEncodings[i], outputCallbacks[i]);
       }
 
       this.output = [];