Skip to content

Commit 826fd35

Browse files
jirutkaruyadorno
authored andcommitted
build: compile bundled simdjson conditionally
The --shared-simdjson flag was introduced in #52924, but the implementation was incomplete. Resolves #52914 PR-URL: #55886 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Richard Lau <[email protected]>
1 parent 1015b22 commit 826fd35

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

node.gyp

-3
Original file line numberDiff line numberDiff line change
@@ -857,7 +857,6 @@
857857
'dependencies': [
858858
'deps/googletest/googletest.gyp:gtest_prod',
859859
'deps/histogram/histogram.gyp:histogram',
860-
'deps/simdjson/simdjson.gyp:simdjson',
861860
'deps/simdutf/simdutf.gyp:simdutf',
862861
'deps/nbytes/nbytes.gyp:nbytes',
863862
'node_js2c#host',
@@ -1180,7 +1179,6 @@
11801179
'deps/googletest/googletest.gyp:gtest',
11811180
'deps/googletest/googletest.gyp:gtest_main',
11821181
'deps/histogram/histogram.gyp:histogram',
1183-
'deps/simdjson/simdjson.gyp:simdjson',
11841182
'deps/simdutf/simdutf.gyp:simdutf',
11851183
'deps/nbytes/nbytes.gyp:nbytes',
11861184
],
@@ -1373,7 +1371,6 @@
13731371
'<(node_lib_target_name)',
13741372
'deps/histogram/histogram.gyp:histogram',
13751373
'deps/nbytes/nbytes.gyp:nbytes',
1376-
'deps/simdjson/simdjson.gyp:simdjson',
13771374
'deps/simdutf/simdutf.gyp:simdutf',
13781375
],
13791376

node.gypi

+4
Original file line numberDiff line numberDiff line change
@@ -216,6 +216,10 @@
216216
'dependencies': [ 'deps/ada/ada.gyp:ada' ],
217217
}],
218218

219+
[ 'node_shared_simdjson=="false"', {
220+
'dependencies': [ 'deps/simdjson/simdjson.gyp:simdjson' ],
221+
}],
222+
219223
[ 'node_shared_brotli=="false"', {
220224
'dependencies': [ 'deps/brotli/brotli.gyp:brotli' ],
221225
}],

0 commit comments

Comments
 (0)