Skip to content

Commit 83c9364

Browse files
BridgeARcodebytere
authored andcommitted
lib: update TODO comments
This removes one TODO comment and adds another that indicates that readline is currently not able to trigger specific escape sequences. Signed-off-by: Ruben Bridgewater <[email protected]> PR-URL: #33361 Reviewed-By: Anto Aravinth <[email protected]>
1 parent dfa8028 commit 83c9364

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

lib/readline.js

+5-1
Original file line numberDiff line numberDiff line change
@@ -848,6 +848,8 @@ Interface.prototype._ttyWrite = function(s, key) {
848848
if (key.ctrl && key.shift) {
849849
/* Control and shift pressed */
850850
switch (key.name) {
851+
// TODO(BridgeAR): The transmitted escape sequence is `\b` and that is
852+
// identical to <ctrl>-h. It should have a unique escape sequence.
851853
case 'backspace':
852854
this._deleteLineLeft();
853855
break;
@@ -945,8 +947,10 @@ Interface.prototype._ttyWrite = function(s, key) {
945947
}
946948
break;
947949

948-
// TODO(BridgeAR): This seems broken?
949950
case 'w': // Delete backwards to a word boundary
951+
// TODO(BridgeAR): The transmitted escape sequence is `\b` and that is
952+
// identical to <ctrl>-h. It should have a unique escape sequence.
953+
// Falls through
950954
case 'backspace':
951955
this._deleteWordLeft();
952956
break;

test/parallel/test-assert-deep.js

-2
Original file line numberDiff line numberDiff line change
@@ -958,8 +958,6 @@ assertDeepAndStrictEqual(obj1, obj2);
958958

959959
// Check proxies.
960960
{
961-
// TODO(BridgeAR): Check if it would not be better to detect proxies instead
962-
// of just using the proxy value.
963961
const arrProxy = new Proxy([1, 2], {});
964962
assert.deepStrictEqual(arrProxy, [1, 2]);
965963
const tmp = util.inspect.defaultOptions;

0 commit comments

Comments
 (0)