Skip to content

Commit 83cbf31

Browse files
gireeshpunathilevanlucas
authored andcommitted
test: avoid usage of mixed IPV6 addresses
The test case fails in AIX due to the mixed-use of unspecified and loopback addresses. This is not a problem in most platforms but fails in AIX. (In Windows too, but does not manifest as the test is omitted in Windows for a different reason). There exists no documented evidence which supports the mixed use of unspecified and loopback addresses. While AIX strictly follows the IPV6 specification with respect to unspecified address ('::') and loopback address ('::1'), the test case latches on to the behavior exhibited by other platforms, and hence it fails in AIX. The proposed fix is to make it work in all platforms including AIX by using the loopback address for the client to connect, as that is the address at which the server listens. Fixes: #7563 PR-URL: #7702 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
1 parent 4b320ad commit 83cbf31

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

test/parallel/test-cluster-disconnect-handles.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ if (cluster.isMaster) {
9292
debugger;
9393
};
9494
if (common.hasIPv6)
95-
server.listen(cb);
95+
server.listen(0, '::1', cb);
9696
else
9797
server.listen(0, common.localhostIPv4, cb);
9898
process.on('disconnect', process.exit);

0 commit comments

Comments
 (0)