module: fix error message about importing names from cjs

When importing specific names from a CJS module, and renaming them using
`as`, the example fix in the error message erroneously contains the
keyword `as` in the destructuring variable declaration.

Example of this issue:

    import { parse as acornParse } from "acorn";
             ^^^^^
    SyntaxError: The requested module 'acorn' is expected to be of type CommonJS, which does not support named exports. CommonJS modules can be imported by importing the default export.
    For example:
    import pkg from 'acorn';
    const { parse as acornParse } = pkg;

PR-URL: #33882
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Guy Bedford <[email protected]>
Reviewed-By: Myles Borins <[email protected]>

Author: fabiosantoscode

lib/internal/modules/esm/module_job.js

@@ -8,6 +8,7 @@ const {
   SafePromise,
   StringPrototypeIncludes,
   StringPrototypeMatch,
+  StringPrototypeReplace,
   StringPrototypeSplit,
 } = primordials;
 
@@ -109,13 +110,14 @@ class ModuleJob {
         if (format === 'commonjs') {
           const importStatement = splitStack[1];
           const namedImports = StringPrototypeMatch(importStatement, /{.*}/)[0];
+          const destructuringAssignment = StringPrototypeReplace(namedImports, /\s+as\s+/g, ': ');
           e.message = `The requested module '${childSpecifier}' is expected ` +
             'to be of type CommonJS, which does not support named exports. ' +
             'CommonJS modules can be imported by importing the default ' +
             'export.\n' +
             'For example:\n' +
             `import pkg from '${childSpecifier}';\n` +
-            `const ${namedImports} = pkg;`;
+            `const ${destructuringAssignment} = pkg;`;
           const newStack = StringPrototypeSplit(e.stack, '\n');
           newStack[3] = `SyntaxError: ${e.message}`;
           e.stack = ArrayPrototypeJoin(newStack, '\n');

test/es-module/test-esm-cjs-named-error.mjs

@@ -10,6 +10,13 @@ const expectedRelative = 'The requested module \'./fail.cjs\' is expected to ' +
   'import pkg from \'./fail.cjs\';\n' +
   'const { comeOn } = pkg;';
 
+const expectedRenamed = 'The requested module \'./fail.cjs\' is expected to ' +
+  'be of type CommonJS, which does not support named exports. CommonJS ' +
+  'modules can be imported by importing the default export.\n' +
+  'For example:\n' +
+  'import pkg from \'./fail.cjs\';\n' +
+  'const { comeOn: comeOnRenamed } = pkg;';
+
 const expectedPackageHack = 'The requested module \'./json-hack/fail.js\' is ' +
   'expected to be of type CommonJS, which does not support named exports. ' +
   'CommonJS modules can be imported by importing the default export.\n' +
@@ -38,6 +45,13 @@ rejects(async () => {
   message: expectedRelative
 }, 'should support relative specifiers with double quotes');
 
+rejects(async () => {
+  await import(`${fixtureBase}/renamed-import.mjs`);
+}, {
+  name: 'SyntaxError',
+  message: expectedRenamed
+}, 'should correctly format named imports with renames');
+
 rejects(async () => {
   await import(`${fixtureBase}/json-hack.mjs`);
 }, {

test/fixtures/es-modules/package-cjs-named-error/renamed-import.mjs

@@ -0,0 +1 @@
+import { comeOn as comeOnRenamed } from "./fail.cjs"