Skip to content

Commit 84d498c

Browse files
yhwangtargos
authored andcommitted
build: skip cctest on Windows shared lib build
cctest depends on some internal APIs which don't declare `__declspec(dllexport)` and causes build failure when building node as shared lib on Windows. Since we already have good test coverage in static lib, we decide to skip the cctest in shared lib build on Windows. Signed-off-by: Yihong Wang <[email protected]> PR-URL: #21228 Reviewed-By: Refael Ackermann <[email protected]>
1 parent 5d5c3fa commit 84d498c

File tree

2 files changed

+5
-0
lines changed

2 files changed

+5
-0
lines changed

node.gyp

+4
Original file line numberDiff line numberDiff line change
@@ -1001,6 +1001,10 @@
10011001
['OS=="solaris"', {
10021002
'ldflags': [ '-I<(SHARED_INTERMEDIATE_DIR)' ]
10031003
}],
1004+
# Skip cctest while building shared lib node for Windows
1005+
[ 'OS=="win" and node_shared=="true"', {
1006+
'type': 'none',
1007+
}],
10041008
],
10051009
}
10061010
], # end targets

vcbuild.bat

+1
Original file line numberDiff line numberDiff line change
@@ -529,6 +529,7 @@ if "%test_args%"=="" goto test-v8
529529
if "%config%"=="Debug" set test_args=--mode=debug %test_args%
530530
if "%config%"=="Release" set test_args=--mode=release %test_args%
531531
if defined no_cctest echo Skipping cctest because no-cctest was specified && goto run-test-py
532+
if not exist %config%\cctest.exe goto run-test-py
532533
echo running 'cctest %cctest_args%'
533534
"%config%\cctest" %cctest_args%
534535
:run-test-py

0 commit comments

Comments
 (0)