Skip to content

Commit 85d152f

Browse files
committed
tools: allow the travis commit message job to fail
Travis often fails due to a commit message that does not adhere to the commit guidelines. We are able to fix the commit message while landing and it often confuses new contributors that travis fails. Keeping the check in place but allowing a test failure to report success should be a good middle ground. PR-URL: #31116 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
1 parent efa0bd8 commit 85d152f

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

.travis.yml

+1
Original file line numberDiff line numberDiff line change
@@ -85,3 +85,4 @@ jobs:
8585
- flake8 . --count --select=E9,F63,F7,F82 --show-source --statistics
8686
allow_failures: # TODO (cclauss): remove this when dependencies are clean
8787
- name: "Find syntax errors in our Python dependencies"
88+
- name: "First commit message adheres to guidelines at <a href=\"https://goo.gl/p2fr5Q\">https://goo.gl/p2fr5Q</a>"

0 commit comments

Comments
 (0)