Skip to content

Commit 88baf98

Browse files
joyeecheungdanielleadams
authored andcommitted
src: do not track BaseObjects directly in Realm
They are referenced through the CleanupQueue which is already tracked. Tracking them again in Realms results in duplicates in the heap snapshot. PR-URL: #46470 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Minwoo Jung <[email protected]>
1 parent c0b6794 commit 88baf98

File tree

1 file changed

+0
-6
lines changed

1 file changed

+0
-6
lines changed

src/node_realm.cc

-6
Original file line numberDiff line numberDiff line change
@@ -47,12 +47,6 @@ void Realm::MemoryInfo(MemoryTracker* tracker) const {
4747

4848
tracker->TrackField("env", env_);
4949
tracker->TrackField("cleanup_queue", cleanup_queue_);
50-
51-
ForEachBaseObject([&](BaseObject* obj) {
52-
if (obj->IsDoneInitializing()) {
53-
tracker->Track(obj);
54-
}
55-
});
5650
}
5751

5852
void Realm::CreateProperties() {

0 commit comments

Comments
 (0)