Skip to content

Commit 88c4adf

Browse files
danbevrvagg
authored andcommitted
test: remove test case 0 from tls-cnnic-whitelist
I looks like this test has not worked as expected since commit 2bc7841 ("test: use random ports where possible"). The test in that commit checked for `CERT_REVOKED` which was returned by CheckWhitelistedServerCert. CheckWhitelistedServerCert was later removed in commit 6ee4228 ("src: drop CNNIC+StartCom certificate whitelisting"). I'm suggesting that this test case be removed as I don't think it is valid anymore. Backport-PR-URL: #20776 PR-URL: #19767 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
1 parent 64b4ea4 commit 88c4adf

File tree

1 file changed

+0
-16
lines changed

1 file changed

+0
-16
lines changed

test/parallel/test-tls-cnnic-whitelist.js

-16
Original file line numberDiff line numberDiff line change
@@ -14,22 +14,6 @@ function loadPEM(n) {
1414
}
1515

1616
const testCases = [
17-
{ // Test 0: for the check of a cert not existed in the whitelist.
18-
// agent7-cert.pem is issued by the fake CNNIC root CA so that its
19-
// hash is not listed in the whitelist.
20-
// fake-cnnic-root-cert has the same subject name as the original
21-
// rootCA.
22-
serverOpts: {
23-
key: loadPEM('agent7-key'),
24-
cert: loadPEM('agent7-cert')
25-
},
26-
clientOpts: {
27-
port: undefined,
28-
rejectUnauthorized: true,
29-
ca: [loadPEM('fake-cnnic-root-cert')]
30-
},
31-
errorCode: 'CERT_HAS_EXPIRED'
32-
},
3317
// Test 1: for the fix of node#2061
3418
// agent6-cert.pem is signed by intermediate cert of ca3.
3519
// The server has a cert chain of agent6->ca3->ca1(root) but

0 commit comments

Comments
 (0)