Skip to content

Commit 88d760c

Browse files
Trotttargos
authored andcommitted
benchmark: fix benchmark/run.js handling of --set
run.js does not work with --set as it tries to include it as options to `fork()` rather than as part of argv for `fork()`. This doesn't throw an error because of a quirk in `fork()` that silently accepts arrays for options objects. This will be changing in Node.js 18.x. PR-URL: #41334 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
1 parent 1150963 commit 88d760c

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

benchmark/run.js

+1-2
Original file line numberDiff line numberDiff line change
@@ -42,8 +42,7 @@ if (format === 'csv') {
4242
const filename = benchmarks[i];
4343
const child = fork(
4444
path.resolve(__dirname, filename),
45-
cli.test ? ['--test'] : [],
46-
cli.optional.set
45+
cli.test ? ['--test'] : cli.optional.set
4746
);
4847

4948
if (format !== 'csv') {

0 commit comments

Comments
 (0)