Skip to content

Commit 88ed027

Browse files
committedOct 11, 2022
deps: V8: cherry-pick 7ddb8399f9f1
Original commit message: [msvc] fix ambiguous call to function in assembler test MSVC is confused by initializer list and default parameter, and reports an ambiguous call. test/cctest/test-assembler-arm64.cc(12208): error C2668: 'v8::internal::Clobber': ambiguous call to overloaded function test-utils-arm64.h(251): note: could be 'void v8::internal::Clobber(v8::internal::MacroAssembler *,v8::internal::CPURegList)' test-utils-arm64.h(241): note: or 'void v8::internal::Clobber(v8::internal::MacroAssembler *,v8::internal::RegList,const uint64_t)' Solution is to construct with explicit type. Bug: v8:13312 Change-Id: I66f5ba48bcdf6eb30035beaf7214a3d26fc9f18b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3913034 Reviewed-by: Igor Sheludko <[email protected]> Commit-Queue: Jakob Kummerow <[email protected]> Reviewed-by: Jakob Kummerow <[email protected]> Cr-Commit-Position: refs/heads/main@{#83406} Refs: v8/v8@7ddb839 PR-URL: #44741 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: James M Snell <[email protected]>
1 parent 26c651c commit 88ed027

File tree

2 files changed

+11
-11
lines changed

2 files changed

+11
-11
lines changed
 

‎common.gypi

+1-1
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@
3636

3737
# Reset this number to 0 on major V8 upgrades.
3838
# Increment by one for each non-official patch applied to deps/v8.
39-
'v8_embedder_string': '-node.9',
39+
'v8_embedder_string': '-node.10',
4040

4141
##### V8 defaults for Node.js #####
4242

‎deps/v8/test/cctest/test-assembler-arm64.cc

+10-10
Original file line numberDiff line numberDiff line change
@@ -12179,35 +12179,35 @@ TEST(peek_poke_unaligned) {
1217912179
// x0-x6 should be unchanged.
1218012180
// w10-w12 should contain the lower words of x0-x2.
1218112181
__ Poke(x0, 1);
12182-
Clobber(&masm, {x0});
12182+
Clobber(&masm, RegList{x0});
1218312183
__ Peek(x0, 1);
1218412184
__ Poke(x1, 2);
12185-
Clobber(&masm, {x1});
12185+
Clobber(&masm, RegList{x1});
1218612186
__ Peek(x1, 2);
1218712187
__ Poke(x2, 3);
12188-
Clobber(&masm, {x2});
12188+
Clobber(&masm, RegList{x2});
1218912189
__ Peek(x2, 3);
1219012190
__ Poke(x3, 4);
12191-
Clobber(&masm, {x3});
12191+
Clobber(&masm, RegList{x3});
1219212192
__ Peek(x3, 4);
1219312193
__ Poke(x4, 5);
12194-
Clobber(&masm, {x4});
12194+
Clobber(&masm, RegList{x4});
1219512195
__ Peek(x4, 5);
1219612196
__ Poke(x5, 6);
12197-
Clobber(&masm, {x5});
12197+
Clobber(&masm, RegList{x5});
1219812198
__ Peek(x5, 6);
1219912199
__ Poke(x6, 7);
12200-
Clobber(&masm, {x6});
12200+
Clobber(&masm, RegList{x6});
1220112201
__ Peek(x6, 7);
1220212202

1220312203
__ Poke(w0, 1);
12204-
Clobber(&masm, {w10});
12204+
Clobber(&masm, RegList{w10});
1220512205
__ Peek(w10, 1);
1220612206
__ Poke(w1, 2);
12207-
Clobber(&masm, {w11});
12207+
Clobber(&masm, RegList{w11});
1220812208
__ Peek(w11, 2);
1220912209
__ Poke(w2, 3);
12210-
Clobber(&masm, {w12});
12210+
Clobber(&masm, RegList{w12});
1221112211
__ Peek(w12, 3);
1221212212

1221312213
__ Drop(4);

0 commit comments

Comments
 (0)
Please sign in to comment.