Skip to content

Commit 89113b8

Browse files
committed
lib: refactor to use min/max of validateNumber
Fix NumberIsNaN is called two times and change error code to ERR_OUT_OF_RANGE when RangeError is occurred in test.
1 parent 3bef549 commit 89113b8

File tree

2 files changed

+3
-10
lines changed

2 files changed

+3
-10
lines changed

lib/internal/histogram.js

+2-9
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22

33
const {
44
MapPrototypeEntries,
5-
NumberIsNaN,
65
NumberIsInteger,
76
NumberMAX_SAFE_INTEGER,
87
ObjectFromEntries,
@@ -186,10 +185,7 @@ class Histogram {
186185
percentile(percentile) {
187186
if (!isHistogram(this))
188187
throw new ERR_INVALID_THIS('Histogram');
189-
validateNumber(percentile, 'percentile');
190-
191-
if (NumberIsNaN(percentile) || percentile <= 0 || percentile > 100)
192-
throw new ERR_INVALID_ARG_VALUE.RangeError('percentile', percentile);
188+
validateNumber(percentile, 'percentile', 1, 100);
193189

194190
return this[kHandle]?.percentile(percentile);
195191
}
@@ -201,10 +197,7 @@ class Histogram {
201197
percentileBigInt(percentile) {
202198
if (!isHistogram(this))
203199
throw new ERR_INVALID_THIS('Histogram');
204-
validateNumber(percentile, 'percentile');
205-
206-
if (NumberIsNaN(percentile) || percentile <= 0 || percentile > 100)
207-
throw new ERR_INVALID_ARG_VALUE.RangeError('percentile', percentile);
200+
validateNumber(percentile, 'percentile', 1, 100);
208201

209202
return this[kHandle]?.percentileBigInt(percentile);
210203
}

test/sequential/test-performance-eventloopdelay.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@ const { sleep } = require('internal/util');
9191
() => histogram.percentile(i),
9292
{
9393
name: 'RangeError',
94-
code: 'ERR_INVALID_ARG_VALUE'
94+
code: 'ERR_OUT_OF_RANGE'
9595
}
9696
);
9797
});

0 commit comments

Comments
 (0)