Skip to content

Commit 89ba5f4

Browse files
TrottBethGriggs
authored andcommitted
doc: revise "Breaking Changes" section of Collaborator Guide
Simplify material about TSC approval for breaking changes. Omit extraneous material explaining that purely additive changes are not breaking changes. PR-URL: #25071 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Anto Aravinth <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: James M Snell <[email protected]>
1 parent 77cf877 commit 89ba5f4

File tree

1 file changed

+2
-7
lines changed

1 file changed

+2
-7
lines changed

COLLABORATOR_GUIDE.md

+2-7
Original file line numberDiff line numberDiff line change
@@ -242,8 +242,8 @@ For undocumented APIs that are public, open a pull request documenting the API.
242242

243243
### Breaking Changes
244244

245-
Backwards-incompatible changes may land on the master branch at any time after
246-
sufficient review by Collaborators and approval of at least two TSC members.
245+
At least two TSC members must approve backward-incompatible changes to the
246+
master branch.
247247

248248
Examples of breaking changes include:
249249

@@ -254,11 +254,6 @@ Examples of breaking changes include:
254254
* altering expected timing of an event
255255
* changing the side effects of using a particular API
256256

257-
Purely additive changes (e.g. adding new events to `EventEmitter`
258-
implementations, adding new arguments to a method in a way that allows
259-
existing code to continue working without modification, or adding new
260-
properties to an options argument) are semver-minor changes.
261-
262257
#### Breaking Changes and Deprecations
263258

264259
With a few exceptions outlined below, when backward-incompatible changes to a

0 commit comments

Comments
 (0)