dns: simplify dns.promises warning logic

dns.promises is lazy loaded. Instead of using a seaparate
Boolean flag to track whether or not it has been loaded, just
inspect the state of the lazy loaded module itself.

PR-URL: #24788
Reviewed-By: Anto Aravinth <[email protected]>
Reviewed-By: Weijia Wang <[email protected]>
Reviewed-By: Masashi Hirano <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>

Author: cjihrig

lib/dns.js

@@ -49,8 +49,7 @@ const {
 
 const dnsException = errors.dnsException;
 
-let promisesWarn = true;
-let promises; // Lazy loaded
+let promises = null; // Lazy loaded
 
 function onlookup(err, addresses) {
   if (err) {
@@ -267,7 +266,7 @@ function defaultResolverSetServers(servers) {
   setDefaultResolver(resolver);
   bindDefaultResolver(module.exports, Resolver.prototype);
 
-  if (promises !== undefined)
+  if (promises !== null)
     bindDefaultResolver(promises, promises.Resolver.prototype);
 }
 
@@ -316,10 +315,9 @@ Object.defineProperties(module.exports, {
     configurable: true,
     enumerable: false,
     get() {
-      if (promisesWarn) {
+      if (promises === null) {
         promises = require('internal/dns/promises');
         promises.setServers = defaultResolverSetServers;
-        promisesWarn = false;
         process.emitWarning('The dns.promises API is experimental',
                             'ExperimentalWarning');
       }