Skip to content

Commit 8b97e2e

Browse files
targosrichardlau
authored andcommitted
build: add -flax-vector-conversions to V8 build
The flag is on by default in Clang and V8 recently made a change that makes it necessary with GCC. Refs: v8/v8@7fbbf93 Refs: https://github.com/llvm/llvm-project/blob/54067c5fbe9fc13ab195cdddb8f17e18d72b5fe4/clang/include/clang/Basic/LangOptions.def#L133-L134 Refs: https://gcc.gnu.org/onlinedocs/gcc/C-Dialect-Options.html#index-flax-vector-conversions PR-URL: #51257 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Marco Ippolito <[email protected]>
1 parent c7aa397 commit 8b97e2e

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

tools/v8_gypfiles/toolchain.gypi

+5-1
Original file line numberDiff line numberDiff line change
@@ -138,7 +138,11 @@
138138
'cflags': [ '-Werror', '-Wno-unknown-pragmas' ],
139139
},{
140140
'cflags!': [ '-Wall', '-Wextra' ],
141-
'cflags': [ '-Wno-return-type' ],
141+
'cflags': [
142+
'-Wno-return-type',
143+
# On by default in Clang and V8 requires it at least for arm64.
144+
'-flax-vector-conversions',
145+
],
142146
}],
143147
['v8_target_arch=="arm"', {
144148
'defines': [

0 commit comments

Comments
 (0)