Skip to content

Commit 8bd2f4e

Browse files
aduh95targos
authored andcommitted
test: use assert.match() instead of assert(regex.test())
PR-URL: #42803 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
1 parent 112bce3 commit 8bd2f4e

File tree

1 file changed

+18
-18
lines changed

1 file changed

+18
-18
lines changed

test/parallel/test-runner-cli.js

+18-18
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ const testFixtures = fixtures.path('test-runner');
1414
assert.strictEqual(child.status, 1);
1515
assert.strictEqual(child.signal, null);
1616
assert.strictEqual(child.stdout.toString(), '');
17-
assert(/^Could not find/.test(child.stderr.toString()));
17+
assert.match(child.stderr.toString(), /^Could not find/);
1818
}
1919

2020
{
@@ -27,11 +27,11 @@ const testFixtures = fixtures.path('test-runner');
2727
assert.strictEqual(child.signal, null);
2828
assert.strictEqual(child.stderr.toString(), '');
2929
const stdout = child.stdout.toString();
30-
assert(/ok 1 - .+index\.test\.js/.test(stdout));
31-
assert(/not ok 2 - .+random\.test\.mjs/.test(stdout));
32-
assert(/not ok 1 - this should fail/.test(stdout));
33-
assert(/ok 3 - .+subdir.+subdir_test\.js/.test(stdout));
34-
assert(/ok 4 - .+random\.cjs/.test(stdout));
30+
assert.match(stdout, /ok 1 - .+index\.test\.js/);
31+
assert.match(stdout, /not ok 2 - .+random\.test\.mjs/);
32+
assert.match(stdout, /not ok 1 - this should fail/);
33+
assert.match(stdout, /ok 3 - .+subdir.+subdir_test\.js/);
34+
assert.match(stdout, /ok 4 - .+random\.cjs/);
3535
}
3636

3737
{
@@ -59,11 +59,11 @@ const testFixtures = fixtures.path('test-runner');
5959
assert.strictEqual(child.signal, null);
6060
assert.strictEqual(child.stderr.toString(), '');
6161
const stdout = child.stdout.toString();
62-
assert(/not ok 1 - .+index\.js/.test(stdout));
63-
assert(/ok 2 - .+index\.test\.js/.test(stdout));
64-
assert(/not ok 3 - .+random\.test\.mjs/.test(stdout));
65-
assert(/not ok 1 - this should fail/.test(stdout));
66-
assert(/ok 4 - .+subdir.+subdir_test\.js/.test(stdout));
62+
assert.match(stdout, /not ok 1 - .+index\.js/);
63+
assert.match(stdout, /ok 2 - .+index\.test\.js/);
64+
assert.match(stdout, /not ok 3 - .+random\.test\.mjs/);
65+
assert.match(stdout, /not ok 1 - this should fail/);
66+
assert.match(stdout, /ok 4 - .+subdir.+subdir_test\.js/);
6767
}
6868

6969
{
@@ -75,7 +75,7 @@ const testFixtures = fixtures.path('test-runner');
7575
assert.strictEqual(child.signal, null);
7676
assert.strictEqual(child.stderr.toString(), '');
7777
const stdout = child.stdout.toString();
78-
assert(/not ok 1 - .+test-nm\.js/.test(stdout));
78+
assert.match(stdout, /not ok 1 - .+test-nm\.js/);
7979
}
8080

8181
{
@@ -88,11 +88,11 @@ const testFixtures = fixtures.path('test-runner');
8888
assert.strictEqual(child.signal, null);
8989
assert.strictEqual(child.stderr.toString(), '');
9090
const stdout = child.stdout.toString();
91-
assert(/ok 1 - .+index\.test\.js/.test(stdout));
92-
assert(/not ok 2 - .+random\.test\.mjs/.test(stdout));
93-
assert(/not ok 1 - this should fail/.test(stdout));
94-
assert(/ok 3 - .+subdir.+subdir_test\.js/.test(stdout));
95-
assert(/ok 4 - .+random\.cjs/.test(stdout));
91+
assert.match(stdout, /ok 1 - .+index\.test\.js/);
92+
assert.match(stdout, /not ok 2 - .+random\.test\.mjs/);
93+
assert.match(stdout, /not ok 1 - this should fail/);
94+
assert.match(stdout, /ok 3 - .+subdir.+subdir_test\.js/);
95+
assert.match(stdout, /ok 4 - .+random\.cjs/);
9696
}
9797

9898
{
@@ -118,6 +118,6 @@ const testFixtures = fixtures.path('test-runner');
118118
assert.strictEqual(child.signal, null);
119119
assert.strictEqual(child.stdout.toString(), '');
120120
const stderr = child.stderr.toString();
121-
assert(/--test/.test(stderr));
121+
assert.match(stderr, /--test/);
122122
});
123123
}

0 commit comments

Comments
 (0)