Skip to content

Commit 8c48302

Browse files
Jayasankar-mBethGriggs
authored andcommitted
src: elevate v8 namespaces for node_url.cc
Elevate namespace for repeated entities. PR-URL: #24573 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
1 parent e464a1d commit 8c48302

File tree

1 file changed

+7
-6
lines changed

1 file changed

+7
-6
lines changed

src/node_url.cc

+7-6
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ using v8::Integer;
2020
using v8::Isolate;
2121
using v8::Local;
2222
using v8::MaybeLocal;
23+
using v8::NewStringType;
2324
using v8::Null;
2425
using v8::Object;
2526
using v8::String;
@@ -30,7 +31,7 @@ using v8::Value;
3031
inline Local<String> Utf8String(Isolate* isolate, const std::string& str) {
3132
return String::NewFromUtf8(isolate,
3233
str.data(),
33-
v8::NewStringType::kNormal,
34+
NewStringType::kNormal,
3435
str.length()).ToLocalChecked();
3536
}
3637

@@ -2158,7 +2159,7 @@ static void Parse(Environment* env,
21582159
argv[ERR_ARG_INPUT] =
21592160
String::NewFromUtf8(env->isolate(),
21602161
input,
2161-
v8::NewStringType::kNormal).ToLocalChecked();
2162+
NewStringType::kNormal).ToLocalChecked();
21622163
error_cb.As<Function>()->Call(context, recv, arraysize(argv), argv)
21632164
.FromMaybe(Local<Value>());
21642165
}
@@ -2208,7 +2209,7 @@ static void EncodeAuthSet(const FunctionCallbackInfo<Value>& args) {
22082209
args.GetReturnValue().Set(
22092210
String::NewFromUtf8(env->isolate(),
22102211
output.c_str(),
2211-
v8::NewStringType::kNormal).ToLocalChecked());
2212+
NewStringType::kNormal).ToLocalChecked());
22122213
}
22132214

22142215
static void ToUSVString(const FunctionCallbackInfo<Value>& args) {
@@ -2242,7 +2243,7 @@ static void ToUSVString(const FunctionCallbackInfo<Value>& args) {
22422243
args.GetReturnValue().Set(
22432244
String::NewFromTwoByte(env->isolate(),
22442245
*value,
2245-
v8::NewStringType::kNormal,
2246+
NewStringType::kNormal,
22462247
n).ToLocalChecked());
22472248
}
22482249

@@ -2263,7 +2264,7 @@ static void DomainToASCII(const FunctionCallbackInfo<Value>& args) {
22632264
args.GetReturnValue().Set(
22642265
String::NewFromUtf8(env->isolate(),
22652266
out.c_str(),
2266-
v8::NewStringType::kNormal).ToLocalChecked());
2267+
NewStringType::kNormal).ToLocalChecked());
22672268
}
22682269

22692270
static void DomainToUnicode(const FunctionCallbackInfo<Value>& args) {
@@ -2283,7 +2284,7 @@ static void DomainToUnicode(const FunctionCallbackInfo<Value>& args) {
22832284
args.GetReturnValue().Set(
22842285
String::NewFromUtf8(env->isolate(),
22852286
out.c_str(),
2286-
v8::NewStringType::kNormal).ToLocalChecked());
2287+
NewStringType::kNormal).ToLocalChecked());
22872288
}
22882289

22892290
std::string URL::ToFilePath() const {

0 commit comments

Comments
 (0)