Skip to content

Commit 8d2a256

Browse files
F3n67utargos
authored andcommitted
dns: make promise API fully constructed from lib/internal/dns/promises
PR-URL: #43227 Refs: #43198 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Minwoo Jung <[email protected]>
1 parent 224d3f4 commit 8d2a256

File tree

3 files changed

+12
-5
lines changed

3 files changed

+12
-5
lines changed

lib/dns.js

-2
Original file line numberDiff line numberDiff line change
@@ -415,8 +415,6 @@ ObjectDefineProperties(module.exports, {
415415
get() {
416416
if (promises === null) {
417417
promises = require('internal/dns/promises');
418-
promises.setServers = defaultResolverSetServers;
419-
promises.setDefaultResultOrder = setDefaultResultOrder;
420418
}
421419
return promises;
422420
}

lib/dns/promises.js

+1-3
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
11
'use strict';
22

3-
const dnsPromises = require('internal/dns/promises');
4-
dnsPromises.setServers = require('dns').setServers;
5-
module.exports = dnsPromises;
3+
module.exports = require('internal/dns/promises');

lib/internal/dns/promises.js

+11
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,8 @@ const {
1717
emitInvalidHostnameWarning,
1818
getDefaultVerbatim,
1919
errorCodes: dnsErrorCodes,
20+
setDefaultResultOrder,
21+
setDefaultResolver,
2022
} = require('internal/dns/utils');
2123
const {
2224
NODATA,
@@ -335,11 +337,20 @@ Resolver.prototype.resolve = function resolve(hostname, rrtype) {
335337
return ReflectApply(resolver, this, [hostname]);
336338
};
337339

340+
function defaultResolverSetServers(servers) {
341+
const resolver = new Resolver();
342+
343+
resolver.setServers(servers);
344+
setDefaultResolver(resolver);
345+
bindDefaultResolver(module.exports, Resolver.prototype);
346+
}
338347

339348
module.exports = {
340349
lookup,
341350
lookupService,
342351
Resolver,
352+
setDefaultResultOrder,
353+
setServers: defaultResolverSetServers,
343354

344355
// ERROR CODES
345356
NODATA,

0 commit comments

Comments
 (0)