Skip to content

Commit 8d6b74d

Browse files
woodfairynodejs-github-bot
authored andcommitted
build: enable ASLR (PIE) on OS X
After conducting several benchmarks, I noticed performance losses of 5-10%. As OS X is not a performance critical platform, as already mentioned by @bnoordhuis, I have removed the -no_pie flag at least for this platform. I'd love to enable PIE for other platforms if the 5-10% speed loss is not too high. I would be happy to hear your opinion on this. Refs: #33425 PR-URL: #35704 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
1 parent fff25a0 commit 8d6b74d

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

common.gypi

+1-2
Original file line numberDiff line numberDiff line change
@@ -495,8 +495,7 @@
495495
['_type!="static_library"', {
496496
'xcode_settings': {
497497
'OTHER_LDFLAGS': [
498-
'-Wl,-no_pie',
499-
'-Wl,-search_paths_first',
498+
'-Wl,-search_paths_first'
500499
],
501500
},
502501
}],

0 commit comments

Comments
 (0)