Skip to content

Commit 8daab3b

Browse files
mhdawsonMylesBorins
authored andcommitted
doc: remove 'you' from writing-tests.md
Noticed this while reading through writing-tests.md today. As per style guide avoid the use of you, your etc. Rational as per: http://www2.ivcc.edu/rambo/tip_formal_writing_voice.htm PR-URL: #13319 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
1 parent f2ede07 commit 8daab3b

File tree

1 file changed

+5
-4
lines changed

1 file changed

+5
-4
lines changed

doc/guides/writing-tests.md

+5-4
Original file line numberDiff line numberDiff line change
@@ -233,8 +233,8 @@ For performance considerations, we only use a selected subset of ES.Next
233233
features in JavaScript code in the `lib` directory. However, when writing
234234
tests, for the ease of backporting, it is encouraged to use those ES.Next
235235
features that can be used directly without a flag in [all maintained branches]
236-
(https://github.com/nodejs/lts), you can check [node.green](http://node.green)
237-
for all available features in each release.
236+
(https://github.com/nodejs/lts). [node.green](http://node.green/) lists
237+
available features in each release.
238238

239239
For example:
240240

@@ -275,7 +275,8 @@ These imported tests will be wrapped like this:
275275
/* eslint-enable */
276276
```
277277

278-
If you want to improve tests that have been imported this way, please send
279-
a PR to the upstream project first. When your proposed change is merged in
278+
To improve tests that have been imported this way, please send
279+
a PR to the upstream project first. When the proposed change is merged in
280280
the upstream project, send another PR here to update Node.js accordingly.
281281
Be sure to update the hash in the URL following `WPT Refs:`.
282+

0 commit comments

Comments
 (0)