Skip to content

Commit 8de5eb8

Browse files
committed
deps: V8: cherry-pick 5681a6565828
Original commit message: [rab/gsab] Fix missing assignment in BackingStore::Reallocate See #39945 Bug: v8:11111 Change-Id: I7271a907bf036c18a014b2a13ff5746db622456a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3141581 Reviewed-by: Leszek Swirski <[email protected]> Commit-Queue: Marja Hölttä <[email protected]> Cr-Commit-Position: refs/heads/main@{#76670} Refs: v8/v8@5681a65 Backport-PR-URL: #40285 PR-URL: #39945 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
1 parent 150d816 commit 8de5eb8

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

common.gypi

+1-1
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@
3636

3737
# Reset this number to 0 on major V8 upgrades.
3838
# Increment by one for each non-official patch applied to deps/v8.
39-
'v8_embedder_string': '-node.9',
39+
'v8_embedder_string': '-node.10',
4040

4141
##### V8 defaults for Node.js #####
4242

deps/v8/src/objects/backing-store.cc

+2-1
Original file line numberDiff line numberDiff line change
@@ -766,7 +766,7 @@ std::unique_ptr<BackingStore> BackingStore::EmptyBackingStore(
766766

767767
bool BackingStore::Reallocate(Isolate* isolate, size_t new_byte_length) {
768768
CHECK(!is_wasm_memory_ && !custom_deleter_ && !globally_registered_ &&
769-
free_on_destruct_);
769+
free_on_destruct_ && !is_resizable_);
770770
auto allocator = get_v8_api_array_buffer_allocator();
771771
CHECK_EQ(isolate->array_buffer_allocator(), allocator);
772772
CHECK_EQ(byte_length_, byte_capacity_);
@@ -776,6 +776,7 @@ bool BackingStore::Reallocate(Isolate* isolate, size_t new_byte_length) {
776776
buffer_start_ = new_start;
777777
byte_capacity_ = new_byte_length;
778778
byte_length_ = new_byte_length;
779+
max_byte_length_ = new_byte_length;
779780
return true;
780781
}
781782

0 commit comments

Comments
 (0)