Skip to content

Commit 8fea174

Browse files
danbevaddaleax
authored andcommitted
test: add DISABLED_ prefix to commented out test
Commit 95ab966 ("test: disable MultipleEnvironmentsPerIsolate") commented out MultipleEnvironmentsPerIsolate but it migth be better to disable the test so that this gets reported and not forgotten: YOU HAVE 1 DISABLED TEST PR-URL: #14317 Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
1 parent 1a5927f commit 8fea174

File tree

1 file changed

+1
-3
lines changed

1 file changed

+1
-3
lines changed

test/cctest/test_environment.cc

+1-3
Original file line numberDiff line numberDiff line change
@@ -85,8 +85,7 @@ TEST_F(EnvironmentTest, AtExitWithArgument) {
8585
EXPECT_EQ(arg, cb_1_arg);
8686
}
8787

88-
/*
89-
TEST_F(EnvironmentTest, MultipleEnvironmentsPerIsolate) {
88+
TEST_F(EnvironmentTest, DISABLED_MultipleEnvironmentsPerIsolate) {
9089
const v8::HandleScope handle_scope(isolate_);
9190
const Argv argv;
9291
Env env1 {handle_scope, isolate_, argv};
@@ -101,7 +100,6 @@ TEST_F(EnvironmentTest, MultipleEnvironmentsPerIsolate) {
101100
RunAtExit(*env2);
102101
EXPECT_TRUE(called_cb_2);
103102
}
104-
*/
105103

106104
static void at_exit_callback1(void* arg) {
107105
called_cb_1 = true;

0 commit comments

Comments
 (0)