Skip to content

Commit 9021b0d

Browse files
GauthamBanasandraTrott
authored andcommitted
src: remove icuDataDir from node config
icuDataDir seems to be redundant as it is not used anywhere. Hence removing it. PR-URL: #24780 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Steven R Loomis <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
1 parent 06134e3 commit 9021b0d

File tree

1 file changed

+0
-4
lines changed

1 file changed

+0
-4
lines changed

src/node_config.cc

-4
Original file line numberDiff line numberDiff line change
@@ -49,10 +49,6 @@ static void Initialize(Local<Object> target,
4949
READONLY_TRUE_PROPERTY(target, "hasNodeOptions");
5050
#endif
5151

52-
// TODO(addaleax): This seems to be an unused, private API. Remove it?
53-
READONLY_STRING_PROPERTY(target, "icuDataDir",
54-
per_process_opts->icu_data_dir);
55-
5652
#endif // NODE_HAVE_I18N_SUPPORT
5753

5854
if (env->options()->preserve_symlinks)

0 commit comments

Comments
 (0)