Skip to content

Commit 90be5a1

Browse files
jasnellitaloacasas
authored andcommitted
stream: avoid using forEach
PR-URL: #11582 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
1 parent 2cab00a commit 90be5a1

File tree

2 files changed

+7
-7
lines changed

2 files changed

+7
-7
lines changed

lib/_stream_readable.js

+5-4
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,8 @@ var StringDecoder;
1313

1414
util.inherits(Readable, Stream);
1515

16+
const kProxyEvents = ['error', 'close', 'destroy', 'pause', 'resume'];
17+
1618
function prependListener(emitter, event, fn) {
1719
// Sadly this is not cacheable as some libraries bundle their own
1820
// event emitter implementation with them.
@@ -811,10 +813,9 @@ Readable.prototype.wrap = function(stream) {
811813
}
812814

813815
// proxy certain important events.
814-
const events = ['error', 'close', 'destroy', 'pause', 'resume'];
815-
events.forEach(function(ev) {
816-
stream.on(ev, self.emit.bind(self, ev));
817-
});
816+
for (var n = 0; n < kProxyEvents.length; n++) {
817+
stream.on(kProxyEvents[n], self.emit.bind(self, kProxyEvents[n]));
818+
}
818819

819820
// when we try to consume some more bytes, simply unpause the
820821
// underlying stream.

lib/_stream_wrap.js

+2-3
Original file line numberDiff line numberDiff line change
@@ -118,9 +118,8 @@ StreamWrap.prototype.doWrite = function doWrite(req, bufs) {
118118
const item = self._enqueue('write', req);
119119

120120
self.stream.cork();
121-
bufs.forEach(function(buf) {
122-
self.stream.write(buf, done);
123-
});
121+
for (var n = 0; n < bufs.length; n++)
122+
self.stream.write(bufs[n], done);
124123
self.stream.uncork();
125124

126125
function done(err) {

0 commit comments

Comments
 (0)