Skip to content

Commit 91d99ce

Browse files
committed
lib,test: fix error message check after V8 update
Backport-PR-URL: #29241 PR-URL: #28918 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Rich Trott <[email protected]>
1 parent 027dcff commit 91d99ce

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

lib/internal/modules/cjs/loader.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@ function enrichCJSError(err) {
9797
usage. However, some cases are not matching, cases like import statement
9898
after a comment block and/or after a variable definition.
9999
*/
100-
if (err.message.startsWith('Unexpected token export') ||
100+
if (err.message.startsWith('Unexpected token \'export\'') ||
101101
(/^\s*import(?=[ {'"*])\s*(?![ (])/).test(lineWithErr)) {
102102
process.emitWarning(
103103
'To load an ES module, set "type": "module" in the package.json or use ' +

test/parallel/test-v8-flags.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,6 @@ assert(vm.runInThisContext('%_IsSmi(43)'));
1313

1414
v8.setFlagsFromString('--noallow_natives_syntax');
1515
assert.throws(function() { eval('%_IsSmi(44)'); },
16-
/^SyntaxError: Unexpected token %$/);
16+
/^SyntaxError: Unexpected token '%'$/);
1717
assert.throws(function() { vm.runInThisContext('%_IsSmi(45)'); },
18-
/^SyntaxError: Unexpected token %$/);
18+
/^SyntaxError: Unexpected token '%'$/);

test/parallel/test-vm-basic.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -152,7 +152,7 @@ const vm = require('vm');
152152
);
153153
}, {
154154
type: SyntaxError,
155-
message: 'Unexpected token }'
155+
message: "Unexpected token '}'"
156156
});
157157

158158
// Tests for failed argument validation

0 commit comments

Comments
 (0)