Skip to content

Commit 9293946

Browse files
santigimenoMylesBorins
authored andcommitted
test: move some test from sequential to parallel
The only test with modifications is `test-stdin-child-proc` that was passing when it should not because the exit code of the child process was not being checked. PR-URL: #6087 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Johan BergstrΓΆm <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Claudio Rodriguez <[email protected]>
1 parent b0ba16f commit 9293946

18 files changed

+13
-4
lines changed
File renamed without changes.
File renamed without changes.

β€Žtest/sequential/test-regress-GH-1899.js β€Žtest/parallel/test-regress-GH-1899.js

-1
Original file line numberDiff line numberDiff line change
@@ -17,4 +17,3 @@ child.on('exit', function(code, signal) {
1717
assert.equal(code, 0);
1818
assert.equal(output, 'hello, world!\n');
1919
});
20-

β€Žtest/sequential/test-regress-GH-746.js β€Žtest/parallel/test-regress-GH-746.js

-1
Original file line numberDiff line numberDiff line change
@@ -27,4 +27,3 @@ server.listen(common.PORT, function() {
2727
process.on('exit', function() {
2828
assert.ok(accepted);
2929
});
30-
+13
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,13 @@
1+
'use strict';
2+
// This tests that pausing and resuming stdin does not hang and timeout
3+
// when done in a child process. See test/parallel/test-stdin-pause-resume.js
4+
const common = require('../common');
5+
const assert = require('assert');
6+
const child_process = require('child_process');
7+
const path = require('path');
8+
const cp = child_process.spawn(process.execPath,
9+
[path.resolve(__dirname, 'test-stdin-pause-resume.js')]);
10+
11+
cp.on('exit', common.mustCall((code) => {
12+
assert.equal(code, 0);
13+
}));

β€Žtest/sequential/test-stdin-pipe-resume.js β€Žtest/parallel/test-stdin-pipe-resume.js

-1
Original file line numberDiff line numberDiff line change
@@ -25,4 +25,3 @@ if (process.argv[2] === 'child') {
2525
child.stdin.end();
2626
}, 10);
2727
}
28-

β€Žtest/sequential/test-zerolengthbufferbug.js β€Žtest/parallel/test-zerolengthbufferbug.js

-1
Original file line numberDiff line numberDiff line change
@@ -34,4 +34,3 @@ process.on('exit', function() {
3434
assert.ok(gotResponse);
3535
assert.equal(0, resBodySize);
3636
});
37-

0 commit comments

Comments
Β (0)