Skip to content

Commit 9334e45

Browse files
bnoordhuisdanbev
authored andcommitted
build: remove mips support
Upstream V8 is dropping support for mips/mipsel/mips64/mips64el. This commit removes the build flags from the configure script and some loose ends from the documentation. PR-URL: #26192 Fixes: #26179 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Yang Guo <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]>
1 parent eb9e6c0 commit 9334e45

File tree

3 files changed

+4
-47
lines changed

3 files changed

+4
-47
lines changed

configure.py

+1-44
Original file line numberDiff line numberDiff line change
@@ -45,13 +45,10 @@
4545

4646
valid_os = ('win', 'mac', 'solaris', 'freebsd', 'openbsd', 'linux',
4747
'android', 'aix', 'cloudabi')
48-
valid_arch = ('arm', 'arm64', 'ia32', 'mips', 'mipsel', 'mips64el', 'ppc',
48+
valid_arch = ('arm', 'arm64', 'ia32', 'ppc',
4949
'ppc64', 'x32','x64', 'x86', 'x86_64', 's390', 's390x')
5050
valid_arm_float_abi = ('soft', 'softfp', 'hard')
5151
valid_arm_fpu = ('vfp', 'vfpv3', 'vfpv3-d16', 'neon')
52-
valid_mips_arch = ('loongson', 'r1', 'r2', 'r6', 'rx')
53-
valid_mips_fpu = ('fp32', 'fp64', 'fpxx')
54-
valid_mips_float_abi = ('soft', 'hard')
5552
valid_intl_modes = ('none', 'small-icu', 'full-icu', 'system-icu')
5653
with open ('tools/icu/icu_versions.json') as f:
5754
icu_versions = json.load(f)
@@ -368,30 +365,6 @@
368365
help='ARM FPU mode ({0}) [default: %default]'.format(
369366
', '.join(valid_arm_fpu)))
370367

371-
parser.add_option('--with-mips-arch-variant',
372-
action='store',
373-
dest='mips_arch_variant',
374-
default='r2',
375-
choices=valid_mips_arch,
376-
help='MIPS arch variant ({0}) [default: %default]'.format(
377-
', '.join(valid_mips_arch)))
378-
379-
parser.add_option('--with-mips-fpu-mode',
380-
action='store',
381-
dest='mips_fpu_mode',
382-
default='fp32',
383-
choices=valid_mips_fpu,
384-
help='MIPS FPU mode ({0}) [default: %default]'.format(
385-
', '.join(valid_mips_fpu)))
386-
387-
parser.add_option('--with-mips-float-abi',
388-
action='store',
389-
dest='mips_float_abi',
390-
default='hard',
391-
choices=valid_mips_float_abi,
392-
help='MIPS floating-point ABI ({0}) [default: %default]'.format(
393-
', '.join(valid_mips_float_abi)))
394-
395368
parser.add_option('--with-dtrace',
396369
action='store_true',
397370
dest='with_dtrace',
@@ -851,8 +824,6 @@ def host_arch_cc():
851824
'__aarch64__' : 'arm64',
852825
'__arm__' : 'arm',
853826
'__i386__' : 'ia32',
854-
'__MIPSEL__' : 'mipsel',
855-
'__mips__' : 'mips',
856827
'__PPC64__' : 'ppc64',
857828
'__PPC__' : 'ppc64',
858829
'__x86_64__' : 'x64',
@@ -868,9 +839,6 @@ def host_arch_cc():
868839
if rtn != 's390':
869840
break
870841

871-
if rtn == 'mipsel' and '_LP64' in k:
872-
rtn = 'mips64el'
873-
874842
return rtn
875843

876844

@@ -884,7 +852,6 @@ def host_arch_win():
884852
'AMD64' : 'x64',
885853
'x86' : 'ia32',
886854
'arm' : 'arm',
887-
'mips' : 'mips',
888855
}
889856

890857
return matchup.get(arch, 'ia32')
@@ -916,14 +883,6 @@ def configure_arm(o):
916883
o['variables']['arm_fpu'] = options.arm_fpu or arm_fpu
917884

918885

919-
def configure_mips(o):
920-
can_use_fpu_instructions = (options.mips_float_abi != 'soft')
921-
o['variables']['v8_can_use_fpu_instructions'] = b(can_use_fpu_instructions)
922-
o['variables']['v8_use_mips_abi_hardfloat'] = b(can_use_fpu_instructions)
923-
o['variables']['mips_arch_variant'] = options.mips_arch_variant
924-
o['variables']['mips_fpu_mode'] = options.mips_fpu_mode
925-
926-
927886
def gcc_version_ge(version_checked):
928887
for compiler in [(CC, 'c'), (CXX, 'c++')]:
929888
ok, is_clang, clang_version, compiler_version = \
@@ -963,8 +922,6 @@ def configure_node(o):
963922

964923
if target_arch == 'arm':
965924
configure_arm(o)
966-
elif target_arch in ('mips', 'mipsel', 'mips64el'):
967-
configure_mips(o)
968925

969926
if flavor == 'aix':
970927
o['variables']['node_target_type'] = 'static_library'

doc/api/process.md

+2-2
Original file line numberDiff line numberDiff line change
@@ -528,8 +528,8 @@ added: v0.5.0
528528
The `process.arch` property returns a string identifying the operating system
529529
CPU architecture for which the Node.js binary was compiled.
530530

531-
The current possible values are: `'arm'`, `'arm64'`, `'ia32'`, `'mips'`,
532-
`'mipsel'`, `'ppc'`, `'ppc64'`, `'s390'`, `'s390x'`, `'x32'`, and `'x64'`.
531+
The current possible values are: `'arm'`, `'arm64'`, `'ia32'`,
532+
`'ppc'`, `'ppc64'`, `'s390'`, `'s390x'`, `'x32'`, and `'x64'`.
533533

534534
```js
535535
console.log(`This processor architecture is ${process.arch}`);

doc/onboarding-extras.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -81,5 +81,5 @@ need to be attached anymore, as only important bugfixes will be included.
8181
* `macos`, `windows`, `smartos`, `aix`
8282
* No linux, linux is the implied default
8383
* Architecture labels
84-
* `arm`, `mips`, `s390`, `ppc`
84+
* `arm`, `s390`, `ppc`
8585
* No x86{_64}, since that is the implied default

0 commit comments

Comments
 (0)