Skip to content

Commit 933ff62

Browse files
ChALkeRevanlucas
authored andcommitted
build: respect --shared-* flags for inspector deps
Don't build openssl/http_parser/libuv for v8_inspector if corresponding --shared-* flags were passed to the ./configure script. Fixes: #7478 Fixes: #7583 PR-URL: #7569 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Ali Ijaz Sheikh <[email protected]>
1 parent 8e50413 commit 933ff62

File tree

1 file changed

+17
-5
lines changed

1 file changed

+17
-5
lines changed

node.gyp

+17-5
Original file line numberDiff line numberDiff line change
@@ -830,14 +830,26 @@
830830

831831
'conditions': [
832832
['v8_inspector=="true"', {
833-
'dependencies': [
834-
'deps/openssl/openssl.gyp:openssl',
835-
'deps/http_parser/http_parser.gyp:http_parser',
836-
'deps/uv/uv.gyp:libuv'
837-
],
838833
'sources': [
839834
'src/inspector_socket.cc',
840835
'test/cctest/test_inspector_socket.cc'
836+
],
837+
'conditions': [
838+
[ 'node_shared_openssl=="false"', {
839+
'dependencies': [
840+
'deps/openssl/openssl.gyp:openssl'
841+
]
842+
}],
843+
[ 'node_shared_http_parser=="false"', {
844+
'dependencies': [
845+
'deps/http_parser/http_parser.gyp:http_parser'
846+
]
847+
}],
848+
[ 'node_shared_libuv=="false"', {
849+
'dependencies': [
850+
'deps/uv/uv.gyp:libuv'
851+
]
852+
}]
841853
]
842854
}],
843855
[ 'node_use_v8_platform=="true"', {

0 commit comments

Comments
 (0)