test: harden test-gc-http-client-timeout

* decrease number of requests 500 -> 300
* extract 'cb' to a file-local function

This should make test more reliable and less resource intensive.

PR-URL: #23184
Refs: #23066
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: James M Snell <[email protected]>

Author: lundibundi

test/sequential/test-gc-http-client-timeout.js

@@ -3,7 +3,7 @@
 // just like test-gc-http-client.js,
 // but with a timeout set
 
-require('../common');
+const common = require('../common');
 const onGC = require('../common/ongc');
 
 function serverHandler(req, res) {
@@ -15,46 +15,44 @@ function serverHandler(req, res) {
 }
 
 const http = require('http');
-const todo = 550;
+const todo = 300;
 let done = 0;
 let count = 0;
 let countGC = 0;
 
 console.log(`We should do ${todo} requests`);
 
 const server = http.createServer(serverHandler);
-server.listen(0, getall);
+server.listen(0, common.mustCall(getall));
 
 function getall() {
   if (count >= todo)
     return;
 
-  (function() {
-    function cb(res) {
-      res.resume();
-      done += 1;
-    }
+  const req = http.get({
+    hostname: 'localhost',
+    pathname: '/',
+    port: server.address().port
+  }, cb);
 
-    const req = http.get({
-      hostname: 'localhost',
-      pathname: '/',
-      port: server.address().port
-    }, cb);
+  req.setTimeout(10, function() {
+    console.log('timeout (expected)');
+  });
 
-    req.setTimeout(10, function() {
-      console.log('timeout (expected)');
-    });
-
-    count++;
-    onGC(req, { ongc });
-  })();
+  count++;
+  onGC(req, { ongc });
 
   setImmediate(getall);
 }
 
 for (let i = 0; i < 10; i++)
   getall();
 
+function cb(res) {
+  res.resume();
+  done += 1;
+}
+
 function ongc() {
   countGC++;
 }