Skip to content

Commit 935fd21

Browse files
dirceurvagg
authored andcommitted
doc: clarify error handling in net.createServer
Remove indications that an error argument is sent to the `listen()` callback. Fixes: #5345 PR-URL: #5353 Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trevor Norris <[email protected]>
1 parent 93dce6d commit 935fd21

File tree

1 file changed

+10
-8
lines changed

1 file changed

+10
-8
lines changed

doc/api/net.markdown

+10-8
Original file line numberDiff line numberDiff line change
@@ -48,11 +48,13 @@ Example:
4848
```js
4949
var server = net.createServer((socket) => {
5050
socket.end('goodbye\n');
51+
}).on('error', (err) => {
52+
// handle errors here
53+
throw err;
5154
});
5255

5356
// grab a random port.
54-
server.listen((err) => {
55-
if (err) throw err;
57+
server.listen(() => {
5658
address = server.address();
5759
console.log('opened server on %j', address);
5860
});
@@ -660,9 +662,10 @@ const server = net.createServer((c) => {
660662
c.write('hello\r\n');
661663
c.pipe(c);
662664
});
663-
server.listen(8124, (err) => {
664-
// 'listening' listener
665-
if (err) throw err;
665+
server.on('error', (err) => {
666+
throw err;
667+
});
668+
server.listen(8124, () => {
666669
console.log('server bound');
667670
});
668671
```
@@ -677,9 +680,8 @@ To listen on the socket `/tmp/echo.sock` the third line from the last would
677680
just be changed to
678681

679682
```js
680-
server.listen('/tmp/echo.sock', (err) => {
681-
// 'listening' listener
682-
if (err) throw err;
683+
server.listen('/tmp/echo.sock', () => {
684+
console.log('server bound');
683685
});
684686
```
685687

0 commit comments

Comments
 (0)