Skip to content

Commit 941b023

Browse files
committed
deps: V8: cherry-pick cc9a8a37445e
Original commit message: fix overflow check in error formatting Bug: v8:12494 Change-Id: Iba2684173296aa236f1a1c73a5606c21472eff06 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3426634 Reviewed-by: Jakob Kummerow <[email protected]> Commit-Queue: Gus Caplan <[email protected]> Cr-Commit-Position: refs/heads/main@{#78909} Refs: v8/v8@cc9a8a3
1 parent e64bc43 commit 941b023

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

common.gypi

+1-1
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@
3636

3737
# Reset this number to 0 on major V8 upgrades.
3838
# Increment by one for each non-official patch applied to deps/v8.
39-
'v8_embedder_string': '-node.85',
39+
'v8_embedder_string': '-node.86',
4040

4141
##### V8 defaults for Node.js #####
4242

deps/v8/src/execution/messages.cc

+2-1
Original file line numberDiff line numberDiff line change
@@ -858,7 +858,8 @@ MaybeHandle<Object> ErrorUtils::FormatStackTrace(Isolate* isolate,
858858
Handle<FixedArray> elems = Handle<FixedArray>::cast(raw_stack);
859859

860860
const bool in_recursion = isolate->formatting_stack_trace();
861-
if (!in_recursion) {
861+
const bool has_overflowed = i::StackLimitCheck{isolate}.HasOverflowed();
862+
if (!in_recursion && !has_overflowed) {
862863
Handle<Context> error_context = error->GetCreationContext();
863864
DCHECK(error_context->IsNativeContext());
864865

0 commit comments

Comments
 (0)