Skip to content

Commit 943547a

Browse files
danbevdanielleadams
authored andcommitted
Revert "test: skip different params test for OpenSSL 3.x"
This reverts commit 269f513. Fixes: #38216 PR-URL: #40640 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
1 parent a2fb12f commit 943547a

File tree

1 file changed

+4
-8
lines changed

1 file changed

+4
-8
lines changed

test/parallel/test-crypto-dh-stateless.js

+4-8
Original file line numberDiff line numberDiff line change
@@ -144,17 +144,13 @@ test(crypto.generateKeyPairSync('dh', { group: 'modp5' }),
144144
test(crypto.generateKeyPairSync('dh', { group: 'modp5' }),
145145
crypto.generateKeyPairSync('dh', { prime: group.getPrime() }));
146146

147-
const list = [];
148-
// Same generator, but different primes.
149-
// TODO(danbev) only commenting out this so that we can get our CI build
150-
// to pass. I'll continue looking into the cause/change.
151-
// [{ group: 'modp5' }, { group: 'modp18' }]];
147+
const list = [
148+
// Same generator, but different primes.
149+
[{ group: 'modp5' }, { group: 'modp18' }]];
152150

153151
// TODO(danbev): Take a closer look if there should be a check in OpenSSL3
154152
// when the dh parameters differ.
155153
if (!common.hasOpenSSL3) {
156-
// Same generator, but different primes.
157-
list.push([{ group: 'modp5' }, { group: 'modp18' }]);
158154
// Same primes, but different generator.
159155
list.push([{ group: 'modp5' }, { prime: group.getPrime(), generator: 5 }]);
160156
// Same generator, but different primes.
@@ -167,7 +163,7 @@ for (const [params1, params2] of list) {
167163
crypto.generateKeyPairSync('dh', params2));
168164
}, common.hasOpenSSL3 ? {
169165
name: 'Error',
170-
code: 'ERR_OSSL_DH_INVALID_PUBLIC_KEY'
166+
code: 'ERR_OSSL_MISMATCHING_DOMAIN_PARAMETERS'
171167
} : {
172168
name: 'Error',
173169
code: 'ERR_OSSL_EVP_DIFFERENT_PARAMETERS'

0 commit comments

Comments
 (0)