@@ -144,17 +144,13 @@ test(crypto.generateKeyPairSync('dh', { group: 'modp5' }),
144
144
test ( crypto . generateKeyPairSync ( 'dh' , { group : 'modp5' } ) ,
145
145
crypto . generateKeyPairSync ( 'dh' , { prime : group . getPrime ( ) } ) ) ;
146
146
147
- const list = [ ] ;
148
- // Same generator, but different primes.
149
- // TODO(danbev) only commenting out this so that we can get our CI build
150
- // to pass. I'll continue looking into the cause/change.
151
- // [{ group: 'modp5' }, { group: 'modp18' }]];
147
+ const list = [
148
+ // Same generator, but different primes.
149
+ [ { group : 'modp5' } , { group : 'modp18' } ] ] ;
152
150
153
151
// TODO(danbev): Take a closer look if there should be a check in OpenSSL3
154
152
// when the dh parameters differ.
155
153
if ( ! common . hasOpenSSL3 ) {
156
- // Same generator, but different primes.
157
- list . push ( [ { group : 'modp5' } , { group : 'modp18' } ] ) ;
158
154
// Same primes, but different generator.
159
155
list . push ( [ { group : 'modp5' } , { prime : group . getPrime ( ) , generator : 5 } ] ) ;
160
156
// Same generator, but different primes.
@@ -167,7 +163,7 @@ for (const [params1, params2] of list) {
167
163
crypto . generateKeyPairSync ( 'dh' , params2 ) ) ;
168
164
} , common . hasOpenSSL3 ? {
169
165
name : 'Error' ,
170
- code : 'ERR_OSSL_DH_INVALID_PUBLIC_KEY '
166
+ code : 'ERR_OSSL_MISMATCHING_DOMAIN_PARAMETERS '
171
167
} : {
172
168
name : 'Error' ,
173
169
code : 'ERR_OSSL_EVP_DIFFERENT_PARAMETERS'
0 commit comments