Skip to content

Commit 94746d6

Browse files
apapirovskitargos
authored andcommitted
test: remove outdated, non-functioning test
The timers directory test, utilizing FakeTime, has not worked in quite a while and is not truly testing Node.js behaviour. If a similar test is necessary it would be better suited to libuv on which Node.js relies for timers functionality. PR-URL: #20894 Fixes: #10154 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Backport-PR-URL: #22039 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Minwoo Jung <[email protected]>
1 parent c6a56ae commit 94746d6

File tree

5 files changed

+0
-182
lines changed

5 files changed

+0
-182
lines changed

.gitignore

-1
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,6 @@ deps/npm/node_modules/.bin/
107107
/SHASUMS*.txt*
108108

109109
# test artifacts
110-
tools/faketime
111110
tools/remark-cli/node_modules
112111
tools/remark-preset-lint-node/node_modules
113112
icu_config.gypi

Makefile

-7
Original file line numberDiff line numberDiff line change
@@ -531,13 +531,6 @@ test-addons-clean:
531531
$(RM) test/addons/.buildstamp test/addons/.docbuildstamp
532532
$(MAKE) test-addons-napi-clean
533533

534-
test-timers:
535-
$(MAKE) --directory=tools faketime
536-
$(PYTHON) tools/test.py $(PARALLEL_ARGS) --mode=$(BUILDTYPE_LOWER) timers
537-
538-
test-timers-clean:
539-
$(MAKE) --directory=tools clean
540-
541534
test-async-hooks:
542535
$(PYTHON) tools/test.py $(PARALLEL_ARGS) --mode=$(BUILDTYPE_LOWER) async-hooks
543536

test/timers/test-timers-reliability.js

-54
This file was deleted.

test/timers/testcfg.py

-100
This file was deleted.

tools/Makefile

-20
This file was deleted.

0 commit comments

Comments
 (0)