Skip to content

Commit 9566603

Browse files
vsemozhetbytjasnell
authored andcommittedApr 19, 2018
doc: add hiding comments note to contributor guide
PR-URL: #20149 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ujjwal Sharma <[email protected]>
1 parent 299da1f commit 9566603

File tree

1 file changed

+5
-0
lines changed

1 file changed

+5
-0
lines changed
 

Diff for: ‎doc/guides/contributing/pull-requests.md

+5
Original file line numberDiff line numberDiff line change
@@ -475,6 +475,10 @@ opportunity for the contributor to learn a bit more about the project.
475475
It is always good to clearly indicate nits when you comment: e.g.
476476
`Nit: change foo() to bar(). But this is not blocking.`
477477

478+
If your comments were addressed but were not folded automatically after new
479+
commits or if they proved to be mistaken, please, [hide them][hiding-a-comment]
480+
with the appropriate reason to keep the conversation flow concise and relevant.
481+
478482
### Be aware of the person behind the code
479483

480484
Be aware that *how* you communicate requests and reviews in your feedback can
@@ -658,3 +662,4 @@ you can take a look at the
658662
[https://ci.nodejs.org/]: https://ci.nodejs.org/
659663
[IRC in the #node-dev channel]: https://webchat.freenode.net?channels=node-dev&uio=d4
660664
[Onboarding guide]: ../../onboarding.md
665+
[hiding-a-comment]: https://help.github.com/articles/managing-disruptive-comments/#hiding-a-comment

0 commit comments

Comments
 (0)
Please sign in to comment.