File tree 1 file changed +5
-0
lines changed
1 file changed +5
-0
lines changed Original file line number Diff line number Diff line change @@ -475,6 +475,10 @@ opportunity for the contributor to learn a bit more about the project.
475
475
It is always good to clearly indicate nits when you comment: e.g.
476
476
` Nit: change foo() to bar(). But this is not blocking. `
477
477
478
+ If your comments were addressed but were not folded automatically after new
479
+ commits or if they proved to be mistaken, please, [ hide them] [ hiding-a-comment ]
480
+ with the appropriate reason to keep the conversation flow concise and relevant.
481
+
478
482
### Be aware of the person behind the code
479
483
480
484
Be aware that * how* you communicate requests and reviews in your feedback can
@@ -658,3 +662,4 @@ you can take a look at the
658
662
[ https://ci.nodejs.org/ ] : https://ci.nodejs.org/
659
663
[ IRC in the #node-dev channel ] : https://webchat.freenode.net?channels=node-dev&uio=d4
660
664
[ Onboarding guide ] : ../../onboarding.md
665
+ [ hiding-a-comment ] : https://help.github.com/articles/managing-disruptive-comments/#hiding-a-comment
You can’t perform that action at this time.
0 commit comments